Repository navigation
feat(rdma): add worker facade and registered memory ownership - #39
Merged
thweetkomputer merged 1 commit intoNov 11, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the phase-two RDMA facade and registration layer. Applications can explicitly acquire a worker/context-scoped protection domain, register caller-owned memory, and retain checked slices and operation leases without activating DPDK/SPDK.
Implementation
BYCORF_ENABLE_RDMA, defaulting to off; only enabled builds discover and link libibverbs and librdmacm.RdmaBackend<Worker>with the existing shared ring for descriptor readiness and cancellation. Construction does not access devices, and no additional ring, thread pool, or process-wide blocking mutex is introduced.RegisteredMemory, registration-retaining slices, SGE leases, explicit access permissions, and checkedRemoteMemoryRegion{address, length, rkey}descriptors. Validate QP context/PD, permissions, ranges, and SGE length before producing a lease.RegisterBuffersremains a separate registration contract.This phase provides registration and readiness primitives; connected transfer/IMM protocols and application buffer pools are outside its scope. Slice bounds and exported permission subsets do not restrict the hardware rkey beyond the original MR grants.
Validation
Both configurations used Clang 18, Debug, and
BYCORF_ENABLE_WERROR=ONon Linux ARM64. The RDMA configuration additionally enabledBYCORF_ENABLE_RDMA. DPDK/SPDK stayed at their default disabled setting.The enabled run includes real Soft-RoCE registration/deregistration, real QPs sharing a PD, permission/range/PD checks, device-free failure injection and lifetime tests, and shared-ring readiness/cancellation. Default executable linkage contains no RDMA libraries. clang-format 23.1.1 and
git diff --checkpassed.